This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #7392: Error formatting for Ethereum DApp responses #7393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Error:
prefix that Webkit applies when responding to a request or we lose the json formatting.This pull request fixes #7392
Submitter Checklist:
NSLocalizableString()
Test Plan:
Host a Web3 Call
Sign request cancelled
instead of messy formatting (see issue).If you have Brave Talk Premium, please verify the fix is working there.
This can also be verified using Ethereum Test DApp.
Sign
underPersonal Sign
.Sign
button now displaysERROR: THE USER REJECTED THE REQUEST
ERROR: ("CODE": 4001, 'MESSAGE": "THE USER REJECTED THE REQUEST.)
Screenshots:
brave.talk.error.formatting.mp4
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement